Remove binary packaging support #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
approved these changes
Aug 19, 2021
MarijnS95
added a commit
to MarijnS95/windows-rs
that referenced
this pull request
Aug 19, 2021
The previous commit now uses a different folder for `target_dir`, namely `target/` directly instead of `target/<profile>/deps`. Popping this twice would go outside of the directory containing `target/` and copy DLL files into _every_ folder matching the `<profile>` name (ie. every `debug` folder inside my `Rust/` projects folder). Fixes: 1291b32 ("Remove binary packaging support (microsoft#1067)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves to the simpler model of having the .windows folder relative to the workspace and avoids all of the file copies and cross-crate copying of files as Cargo just isn't up to that at the moment.
Fixes #979