-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Block cursor be on inlay hint #226515
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
c4e5284
to
135a89c
Compare
Working to solve the conflicts... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thank you, it was so annoying.. hoping it gets merged soon!
Hi @hediet, Thank you so much for all the hard work you've done so far! I was wondering if you have an approximate timeline for when we can expect this PR to be merged? Bests, |
All vscode vim extension users will celebrate 🍾 this fix! |
Could we please have this fix go in soon™️. It really is one of the most visually jarring things I've seen in long time and it confuses me several times a day 😅 |
@hediet pinging for reviewing... |
fix #209417
Description
These changes followed #209417 (comment)
Effect
2024-08-24.210436.mp4