Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block cursor be on inlay hint #226515

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

NriotHrreion
Copy link
Contributor

fix #209417

Description

These changes followed #209417 (comment)

Effect

2024-08-24.210436.mp4

Copy link

@concetoMSI concetoMSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@NriotHrreion
Copy link
Contributor Author

Working to solve the conflicts...

@NriotHrreion NriotHrreion reopened this Aug 31, 2024
Copy link

@avan2s avan2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, thx!

Copy link

@andreasvh-conceto andreasvh-conceto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@nkoeppe nkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you, it was so annoying.. hoping it gets merged soon!

@nkoeppe
Copy link

nkoeppe commented Sep 6, 2024

Hi @hediet,

Thank you so much for all the hard work you've done so far! I was wondering if you have an approximate timeline for when we can expect this PR to be merged?

Bests,
Nico

@NriotHrreion
Copy link
Contributor Author

NriotHrreion commented Sep 13, 2024

Also asking when the PR will be reviewed and merged. @hediet
This PR has been opened for a period of time.

The cursor behavior in the issue #209417 is quite unacceptable and uncomfortable. I hope this issue could be fixed as quick as possible.

@andreasvh-conceto
Copy link

andreasvh-conceto commented Sep 13, 2024

All vscode vim extension users will celebrate 🍾 this fix!

@jsfr
Copy link

jsfr commented Nov 8, 2024

Could we please have this fix go in soon™️. It really is one of the most visually jarring things I've seen in long time and it confuses me several times a day 😅

@NriotHrreion
Copy link
Contributor Author

@hediet pinging for reviewing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block cursor should not be on inlay hint
7 participants