Issue 242: Enable XML mode of parsing documents #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
testforstephen
approved these changes
Nov 26, 2024
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to fix the issue #242.
The default parsing of htmlparser2 appears to have a unique handling mechanism for self-closing or void tags. It only parses void tags from a predefined list of known HTML self-closing tags.
<url />is not on the list which makes the parser discard subsequent tags in pom.xml such as<dependencies>and<build>. Here'sxmlModereferenced in htmlparser2.Enabling XML mode fixes the issue, and so the extension is able to edit the existing
<dependencies>body.I only tested the code manually and haven't added any automated tests.