Issue 217: Allow Package Name specification #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using groupId + artifactId as default value
|
@Eskibear could you review this PR or direct to some other contributor with write access? |
|
Thank you for the pr. I haven’t been focusing and watching this repo for a while, and @jdneo @testforstephen are currently working on this project. |
|
@jdneo @testforstephen this PR has been waiting for a review for quite a while, could you take a look? |
|
@brunovieira97 sorry for the late response. I will take a look at your three PRs in the coming 1~2 weeks. |
| } | ||
|
|
||
| private async specifyPackageName(projectMetadata: IProjectMetadata): Promise<boolean> { | ||
| const recommendedPackageName = `${projectMetadata.groupId}.${projectMetadata.artifactId}` |
There was a problem hiding this comment.
since the artifactId allows - in its name, but packageName does not allow it. It's better to replace - with _ when generating the default packageName from groupId and artifactId.
There was a problem hiding this comment.
Hadn't considered that, thanks!
testforstephen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New step for allowing specification of a custom Package Name during project generation.
There is no default setting provided since the recommended value is always based on the combination of Group Id and Artifact Id.
Closes #217