Apply mssql font settings to result grid #18500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssuh
requested review from
kburtram,
aasimkhan30,
caohai,
laurennat,
lewis-sanchez and
Benjin
as code owners
|
Can you add a screenshot showing the change if these are set to a different font and larger size? |
Benjin
reviewed
Dec 11, 2024
| const [fontSize, setFontSize] = useState(""); | ||
|
|
||
| useEffect(() => { | ||
| const getFontFamily = async () => { |
There was a problem hiding this comment.
what does this look like if these settings aren't set? they should default to var(--vscode-editor-font-size) and var(--vscode-editor-font-family)
There was a problem hiding this comment.
Looks like the default behavior is the UI font, not the editor font.
Without these settings, it should look like this:
kburtram
reviewed
Dec 12, 2024
PR Changes
|
|
Chatted with @Benjin and we are expanding the scope of this fix to also adjust row / column sizes dynamically based on the font size that is input, so I will be working on adding that in a larger PR that will be for the January release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the query result grid to use the
mssql.resultsFontFamilyandmssql.resultsFontSizesettings.Example with font size: 20 & mac default font family
Fixes #18351