Add save participant under its own ID to avoid conflicts. #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'org.eclipse.jdt.core' has its own save participant which fails to run and produces "symptoms" like re-indexing all libraries on every project import Signed-off-by: Roland Grunberg <[email protected]>
jdneo
reviewed
Mar 4, 2025
jdneo
approved these changes
Mar 5, 2025
|
@rgrunber There are some issue with our build pipeline recently. I'll make a nightly release once the issue is solved, and a stable one after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Performance issue when enabling Build Server #1441 (comment) for a more thorough explanation.
Also see Slow workspace initialization and reference search in large Gradle monorep redhat-developer/vscode-java#3904
'org.eclipse.jdt.core' has its own save participant which fails to run and produces "symptoms" like re-indexing all libraries on every project import
CC'ing @jdneo , @Eskibear for a better idea if this seems reasonable. From my testing, this improve performance by avoiding re-indexing all libraries every time.