Change fireSoon to take callback function #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
approved these changes
Sep 14, 2023
alexyaang
added a commit
that referenced
this pull request
Sep 21, 2023
* Registries V2 (#4021) * saving progress * added context values for copy full tag * added back copy remote image digest * comment out commands that are not implemented yet * added disconnext registry function back * small fixes to adjust to new changes * Made Some ACR Commands Work (#4027) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * Added Back `createAzureRegistry` command (#4029) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * Added More Commands Back (#4031) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * Added Back Open Docker Hub Item in Browser (#4033) * added view docker hub item in browser command * updated npm package * Added More Commands Back (#4031) * adjusted scheduleRunReuqest to work with new registries tree * delete azure repository command implementation * actually added back delete azure repository * added back delete Azure Registry command * changed registry tree util file name to be more general * added openInAzurePortalCommand * added back create azure registry command * move createAzureClient to azureUtils * added viewAzureProperties command back (partially) * small tweak to make build image in azure work * added untag azure image commad * added logout of docker cli command * add case sensitivity operator to be consistent * Update src/tree/registries/Azure/AzureRegistryDataProvider.ts Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * added void * removed symbol as it already exists --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * minor tweak to avoid index out of bounds * use built in methods to determine the type of item --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * Added Back `pushImage()` (#4034) * make pushImage work * added getAllRegistries command * added getLoginInformation() * account for cases where registry in undefined * added filtering to make get all registries more optima * added logic to filter github repositories * Added Back Azure Deploy to ACA & Azure Deploy to AAS (#4038) * added back basic implementation of deploy ACA * saving progress * added step for selecting subscriptions * small tweaks * progress on deploy image to azure app service * improved azure subscription selection experience * actually made deploy image to AAS work * remove accidetal change to settings.json * fix small mistake * fixed more mistakes * fix more mistakes * fixed even more mistakes... * Implemented Delete Remote Image for GenericV2 (#4039) * added logic for copy remote imgage digest * added back delete image * refined logic for delete image * fixed pushImage * reverted changes to registryExperience * tag logic for GitHub * be able to debug github image * added back skipIfOne flag * Added Untag Image Command for Azure RDP (#4041) * adjusted context values * added untag Image * remove github option for delete tag * commtag -> v2tag * slighty changed context values * Improve UX for Connecting & Disconnecting Generic V2 Registries (#4043) * added remove tracked registry command * added command to add generic v2 registry * Update package.nls.json Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * Update package.nls.json Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * added logic for reconnect (#4045) * Cleanup Registries Implementation (#4046) * fixed genericV2 pull image bug * improved utils to use outside methods * enable copyImageDigest for all v2 registries * removed run task & did TODOs * did TODOs * use baseUrl * polished up contextValues * fixed push image error for dockerhub * removed azure account listener * actually removed AzureAccountExtensionListener * made minor adjustments based in brandon's comments * use azutils for open in azure portal * Fix subscription icon * Small fix * minor changes to imports * Remove GitHub package transitive dependency * Version was wrong * allow delete image command show up on commontag * fix miake in deleteImage * simplified logic in pushImage (#4062) * simplify logic in deploy to Azure app service (#4063) * handle contextValueExperience edge case * changed isWrappedItem function name to be more specific * Added fire soon function to AzureRDP (#4066) * added fire soon * clear time out * Change fireSoon to take callback function (#4071) * change firesoon to take callback function * use RDP label when determining type of registry * use new RegistryV2RequestOptions for azure requests * Improve Registry Experience & Simplify Context Values (#4076) * added implementation * added comments * use RegistryQuickPickStep for everything * fix regex * fix viewproperties context value package json * remove unnecessary method * added back necessary logic * Commit current progress * Commit current progress * adjust package.json * fix azure typo * preserve existing additional context value * make regex more robust --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]> * remove unnecessary comment * uploaded & changed azext package version * Asynchronously fetch createdAt info (#4074) * Add registry extensibility capability (#4061) * remove generic v2 root if it's the last one * get registries package from npm * Trigger Build * actually get npm from npm org * update azext util package to use npm org --------- Co-authored-by: Brandon Waterloo [MSFT] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these comments