Add a client for Podman #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
commented
Jan 25, 2024
| @@ -93,7 +93,7 @@ export type ImageNameDefaults = { | |||
| }; | |||
|
|
|||
| export type CommonCommandOptions = { | |||
| shellProvider?: IShell; | |||
| shellProvider?: IShell; // TODO: this seems to be unused | |||
bwateratmsft
commented
Feb 14, 2024
| Env?: Array<string>, | ||
| ExposedPorts?: Record<string, unknown> | null; | ||
|
|
||
| // TODO: validate these remaining properties |
danegsta
reviewed
Feb 14, 2024
| /** | ||
| * The default argument given to `--format` | ||
| */ | ||
| public readonly defaultFormatForJson: string = "{{ json . }}"; |
There was a problem hiding this comment.
nit: should we match the default of "{{json .}}" without the extra whitespace?
danegsta
reviewed
Feb 14, 2024
|
|
||
| const client = new PodmanClient(); | ||
| const runner = new WslShellCommandRunnerFactory({ strict: true }); | ||
| const testDockerfileContext = '/mnt/d/vscode-docker-extensibility/packages/vscode-container-client/src/test/buildContext'; |
There was a problem hiding this comment.
Should use relative paths + path.resolve to map these files.
danegsta
reviewed
Feb 14, 2024
Comment on lines
22
to
25
| // const client = new PodmanClient(); | ||
| // const runner = new ShellStreamCommandRunnerFactory({ strict: true }); | ||
| // const testDockerfileContext = 'D:\\vscode-docker-extensibility\\packages\\vscode-container-client\\src\\test\\buildContext'; | ||
| // const testDockerfile = 'D:\\vscode-docker-extensibility\\packages\\vscode-container-client\\src\\test\\buildContext\\Dockerfile'; |
There was a problem hiding this comment.
Remove commented out code
There was a problem hiding this comment.
The tests are meant to be run locally, with some things commented in/out, so I'd prefer to keep this code. I agree though that the paths should be changed to be relative.
There was a problem hiding this comment.
i.e., I want to be able to quickly switch between running the whole set of tests against Podman in WSL, vs. running them locally in Podman Desktop, by commenting out something and uncommenting something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221
I have tested the following end-to-end (Podman v3):
ContainersStatsCommandN/AListContextsCommandN/ARemoveContextsCommandN/AUseContextCommandN/AInspectContextsCommandN/AI have tested the following end-to-end (Podman v4 via Podman Desktop):
ContainersStatsCommandN/AListContextsCommandN/ARemoveContextsCommandN/AUseContextCommandN/AInspectContextsCommandN/AKnown issues:
https://https://