Added delete image & get digest logic for Generic V2 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
approved these changes
Aug 24, 2023
| }); | ||
| } | ||
|
|
||
| public async getImageDigest(item: CommonTag): Promise<string> { |
There was a problem hiding this comment.
This and deleteTag can probably be in RegistryV2DataProvider (the base class)
There was a problem hiding this comment.
that reminds me, I should look at if that protocol would work with GitHub, theoretically, it would right? but regardless, i think moving it to RegistryV2DataProvider would make sense
There was a problem hiding this comment.
GitHub is fully v2 compliant, or at least, it's supposed to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly addressed adding delete image & get digest logic for Generic V2
I also refactored some of the naming in GenericV2DP since the names I previously gave things didn't really make sense.
Related to microsoft/vscode-docker#4026