Check related files API flag when IntelliSense is disabled #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Sep 19, 2024
sean-mcmanus
deleted the
dev/bemcmorr/check-exp-flag-isense-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to a small issue Bob identified in #12735. When IntelliSense is disabled, the existing behavior is to fall back to also disabling the related files API and registering the
getIncludescommand as a no-op. However, that wouldn't correctly test the eventual migration we want where thegetIncludescommand goes away entirely. I changed this to explicitly check the experiment state on the IntelliSense disabled path too.No need to re-spin any insiders builds for this -- it can go into the next release.