Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs with trusted compiler paths #11998

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Colengms
Copy link
Collaborator

Fixes two bugs with trusted compiler paths:

  1. It's intended that the compilerPath field in c_cpp_properties.json and the C_Cpp.default.compilerPath may actually contain a full command line with compiler arguments. This allows arguments to be specified that contain shell escaping, whereas the compilerArgs array does/must not have shell escaping. This change fixes an issue where the unprocessed compiler path was being passed to the native process, without having yet stripped the compiler args from it, if present. (Note that it may now redundantly provide the same trusted compiler in other scenario, which that shouldn't cause an issue.)

  2. Fixes an issue where, if the native process were to crash, it would not be properly provided the trusted compiler from the base configuration. (It's possible there may still be an issue here related to custom config providers, as custom file and browse configs would need to again be provided to the restarted native process again, and it's unclear to me if that's happening).

@Colengms Colengms marked this pull request as draft February 23, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant