fix: Query Editor toolbar folds to menu to fit the window size #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2472
This pull request includes several significant changes to the
QueryEditorcomponent in thesrc/webviewsdirectory. The most important changes involve replacing theQueryToolbarandResultPanelToolbarcomponents with their respective "Overflow" versions and updating the styling for theResultPanelcomponent.Component replacements:
src/webviews/QueryEditor/QueryPanel/QueryPanel.tsx: ReplacedQueryToolbarwithQueryToolbarOverflow. [1] [2]src/webviews/QueryEditor/ResultPanel/ResultPanel.tsx: ReplacedResultPanelToolbarwithResultPanelToolbarOverflow. [1] [2]Styling updates:
src/webviews/QueryEditor/QueryEditor.tsx: Commented out theminWidthproperty in therootstyle.src/webviews/QueryEditor/ResultPanel/ResultPanel.tsx: AddedflexBasisandminWidthproperties to several style classes to improve layout handling.Component removal:
src/webviews/QueryEditor/QueryPanel/QueryToolbar.tsx: Removed theQueryToolbarcomponent and its associated code.src/webviews/QueryEditor/ResultPanel/ResultPanelToolbar.tsx: Removed theResultPanelToolbarcomponent and its associated code.