unified and simplified vCore telemetry #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's already done via callWithTelemetryAndErrorHandling
bk201-
reviewed
Nov 29, 2024
src/webviews/mongoClusters/collectionView/components/toolbar/ToolbarViewNavigation.tsx
Outdated
Show resolved
Hide resolved
src/webviews/mongoClusters/collectionView/components/toolbar/ToolbarViewNavigation.tsx
Outdated
Show resolved
Hide resolved
src/webviews/mongoClusters/collectionView/components/toolbar/ToolbarViewNavigation.tsx
Outdated
Show resolved
Hide resolved
tnaum-ms
commented
Dec 3, 2024
| result['serverInfo.storageEngines'] = (buildInfo.storageEngines as string[])?.join(';'); | ||
| result['serverInfo.modules'] = (buildInfo.modules as string[])?.join(';'); | ||
| } catch (error) { | ||
| result['serverInfo.error'] = (error as Error).message; |
There was a problem hiding this comment.
Thanks! :) I'll make sure to remember. Thanks for the tip, and please keep sharing them, I'm still catching up with JS/TS.
| sessionId: string; | ||
| databaseName: string; | ||
| collectionName: string; | ||
| collectionTreeItem: CollectionItem; // needed to execute commands on the collection as the tree APIv2 doesn't support id-based search for tree items. | ||
| }; | ||
|
|
||
| export const collectionsViewRouter = router({ | ||
| getInfo: publicProcedure.query(({ ctx }) => { | ||
| getInfo: publicProcedure.use(trpcToTelemetry).query(({ ctx }) => { |
There was a problem hiding this comment.
Interesting. I haven’t seen it so far, but I wasn’t specifically looking for it either. I’ll investigate it if we choose tRPC for the long(er) run.
bk201-
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved vCore's telemetry support. Added telemetry to tRPC communication.