Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removes UI blinking while loading the document #2471

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

bk201-
Copy link
Contributor

@bk201- bk201- commented Nov 26, 2024

Fixes #2457

@bk201- bk201- requested review from a team as code owners November 26, 2024 14:25
tnaum-ms
tnaum-ms previously approved these changes Dec 3, 2024
Copy link
Collaborator

@tnaum-ms tnaum-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, I'd probably go with something like isReady state and make it more general than just that isInit one that's very specific. With isReady you'd be able to cover more cases.

@bk201-
Copy link
Contributor Author

bk201- commented Dec 3, 2024

@tnaum-ms Agree, renamed

@bk201- bk201- merged commit 086f08d into main Dec 4, 2024
2 checks passed
@bk201- bk201- deleted the dev/sda/new-document-loading-blinking branch December 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A brief flash of a screen before the document file is opened in "Cosmos DB for NoSQL" account
3 participants