Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Connector #3790

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Add Service Connector #3790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ecff7c0
Add Service Connector
motm32 Aug 8, 2023
d89cc4c
Requested changes and update package
motm32 Aug 17, 2023
405c9dc
Add name to activity log
motm32 Aug 21, 2023
9ec71b6
Hide validate from the command palette
motm32 Aug 22, 2023
c0369c1
Update package and change create/delete name
motm32 Aug 23, 2023
7b2c561
one more change
motm32 Aug 23, 2023
404d7ef
Update dev and serviceconnector package
motm32 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,18 +639,18 @@
},
{
"command": "azureFunctions.createServiceConnector",
"when": "view == azureResourceGroups && viewItem =~ /serviceConnectorGroupItem/",
"group": "4@1"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /serviceConnectorGroupItem/",
"group": "1@1"
},
{
"command": "azureFunctions.deleteServiceConnector",
"when": "view == azureResourceGroups && viewItem =~ /serviceConnectorItem/",
"group": "4@2"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /serviceConnectorItem/",
"group": "1@1"
},
{
"command": "azureFunctions.validateServiceConnector",
"when": "view == azureResourceGroups && viewItem =~ /serviceConnectorItem/",
"group": "4@3"
"when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /serviceConnectorItem/",
"group": "1@2"
}
],
"explorer/context": [
Expand Down Expand Up @@ -1187,7 +1187,7 @@
"@microsoft/vscode-azext-azureappservice": "^2.2.2",
"@microsoft/vscode-azext-azureappsettings": "^0.2.0",
"@microsoft/vscode-azext-azureutils": "^2.0.1",
"@microsoft/vscode-azext-serviceconnector": "file:../vscode-azuretools/serviceconnector/microsoft-vscode-azext-serviceconnector-0.0.1.tgz",
"@microsoft/vscode-azext-serviceconnector": "0.1.0",
"@microsoft/vscode-azext-utils": "^2.0.0",
"@microsoft/vscode-azureresources-api": "^2.0.4",
"cross-fetch": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"azureFunctions.toggleAppSettingVisibility": "Toggle App Setting Visibility.",
"azureFunctions.uninstallFuncCoreTools": "Uninstall Azure Functions Core Tools",
"azureFunctions.validateFuncCoreTools": "Validate the Azure Functions Core Tools is installed before debugging.",
"azureFunctions.validateServiceConnector": "Validate Service Connector",
"azureFunctions.validateServiceConnector": "Validate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to make the same changes you did on the App Service PR here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm you got it

"azureFunctions.viewCommitInGitHub": "View Commit in GitHub",
"azureFunctions.viewDeploymentLogs": "View Deployment Logs",
"azureFunctions.viewProperties": "View Properties",
Expand Down
2 changes: 1 addition & 1 deletion src/serviceConnector/validateServiceConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function validateServiceConnector(context: IActionContext, item?: S
const activityContext = {
...context,
...await createActivityContext(),
activityTitle: localize('validateServiceConnector', 'Validate Service Connector'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this title to be more detailed. Is it possible to add in the name of what we're validating here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like add in the name of the specific service connector?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel that the activity title should have more detail so it's easy to know what is being validated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at the very least it can be changed back to "Validate Service Connector"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the name of the specific service connector makes the most sense!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

When I do it from the command palette it says Validate undefined

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd be OK just hiding this from the command palette.

activityTitle: localize('validate', 'Validate'),
}

await validateLinker(activityContext, item.id, item.subscription, serviceConnectorName);
Expand Down