-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Service Connector #3790
Merged
Merged
Add Service Connector #3790
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ecff7c0
Add Service Connector
motm32 d89cc4c
Requested changes and update package
motm32 405c9dc
Add name to activity log
motm32 9ec71b6
Hide validate from the command palette
motm32 c0369c1
Update package and change create/delete name
motm32 7b2c561
one more change
motm32 404d7ef
Update dev and serviceconnector package
motm32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.md in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import { ServiceConnectorGroupTreeItem, createLinker } from "@microsoft/vscode-azext-serviceconnector"; | ||
import { IActionContext } from "@microsoft/vscode-azext-utils"; | ||
import { localize } from "../localize"; | ||
import { SlotTreeItem } from "../tree/SlotTreeItem"; | ||
import { createActivityContext } from "../utils/activityUtils"; | ||
import { pickFunctionApp } from "../utils/pickFunctionApp"; | ||
|
||
export async function createServiceConnector(context: IActionContext, item?: SlotTreeItem | ServiceConnectorGroupTreeItem): Promise<void> { | ||
item ??= await pickFunctionApp(context); | ||
|
||
if (item instanceof ServiceConnectorGroupTreeItem) { | ||
item = <SlotTreeItem>item.parent; | ||
} | ||
|
||
const activityContext = { | ||
...context, | ||
...await createActivityContext(), | ||
activityTitle: localize('createServiceConnector', 'Create Service Connector'), | ||
} | ||
|
||
await createLinker(activityContext, item.id, item.subscription); | ||
await item.refresh(context); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.md in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import { ServiceConnectorTreeItem, deleteLinker } from "@microsoft/vscode-azext-serviceconnector"; | ||
import { IActionContext } from "@microsoft/vscode-azext-utils"; | ||
import { localize } from "../localize"; | ||
import { SlotTreeItem } from "../tree/SlotTreeItem"; | ||
import { createActivityContext } from "../utils/activityUtils"; | ||
import { pickFunctionApp } from "../utils/pickFunctionApp"; | ||
|
||
export async function deleteServiceConnector(context: IActionContext, item?: SlotTreeItem | ServiceConnectorTreeItem): Promise<void> { | ||
let serviceConnectorName: string | undefined = undefined; | ||
item ??= await pickFunctionApp(context); | ||
|
||
if (item instanceof ServiceConnectorTreeItem) { | ||
serviceConnectorName = item.label; | ||
item = <SlotTreeItem>item.parent?.parent; | ||
} | ||
|
||
const activityContext = { | ||
...context, | ||
...await createActivityContext(), | ||
activityTitle: localize('deleteServiceConnector', 'Delete Service Connector'), | ||
} | ||
|
||
await deleteLinker(activityContext, item.id, item.subscription, serviceConnectorName); | ||
await item.refresh(context); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.md in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import { ServiceConnectorTreeItem, validateLinker } from "@microsoft/vscode-azext-serviceconnector"; | ||
import { IActionContext } from "@microsoft/vscode-azext-utils"; | ||
import { localize } from "../localize"; | ||
import { SlotTreeItem } from "../tree/SlotTreeItem"; | ||
import { createActivityContext } from "../utils/activityUtils"; | ||
import { pickFunctionApp } from "../utils/pickFunctionApp"; | ||
|
||
export async function validateServiceConnector(context: IActionContext, item?: SlotTreeItem | ServiceConnectorTreeItem): Promise<void> { | ||
let serviceConnectorName: string | undefined = undefined | ||
item ??= await pickFunctionApp(context); | ||
|
||
if (item instanceof ServiceConnectorTreeItem) { | ||
serviceConnectorName = item.label; | ||
item = <SlotTreeItem>item.parent?.parent; | ||
} | ||
|
||
const activityContext = { | ||
...context, | ||
...await createActivityContext(), | ||
activityTitle: localize('validate', 'Validate'), | ||
} | ||
|
||
await validateLinker(activityContext, item.id, item.subscription, serviceConnectorName); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/*--------------------------------------------------------------------------------------------- | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. See License.md in the project root for license information. | ||
*--------------------------------------------------------------------------------------------*/ | ||
|
||
import { ITreeItemPickerContext } from "@microsoft/vscode-azext-utils"; | ||
import { functionFilter } from "../constants"; | ||
import { ext } from "../extensionVariables"; | ||
import { SlotTreeItem } from "../tree/SlotTreeItem"; | ||
|
||
export async function pickFunctionApp(context: ITreeItemPickerContext): Promise<SlotTreeItem> { | ||
return await ext.rgApi.pickAppResource<SlotTreeItem>(context, { | ||
filter: functionFilter | ||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to make the same changes you did on the App Service PR here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm you got it