-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcpkg-tool to 2025-01-11. #43209
Conversation
"os": "linux", | ||
"version": "0.11.0", | ||
"executable": "coscli-linux", | ||
"url": "https://github.com/tencentyun/coscli/releases/download/v0.11.0-beta/coscli-linux", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also run on arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. Unfortunately this file has already been burned into the SHA the tool references so I'd prefer to make improvements like this as a subsequent change unless they are actively broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same SHA as was in the XML:
<tool name="coscli" os="linux">
<version>0.11.0</version>
<exeRelativePath>coscli-linux</exeRelativePath>
<url>https://github.com/tencentyun/coscli/releases/download/v0.11.0-beta/coscli-linux</url>
<sha512>9c930a1d308e9581a0e2fdfe3751ea7fe13d6068df90ca6465740ec3eda034202ef71ec54c99e90015ff81aa68aa1489567db5e411e222eb7258704bdac7e924</sha512>
</tool>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are arch-specific ones in current releases: https://github.com/tencentyun/coscli/releases/tag/v1.0.3
"os": "linux", | ||
"version": "16.15.1", | ||
"executable": "node-v16.15.1-linux-x64/bin/node", | ||
"url": "https://nodejs.org/dist/v16.15.1/node-v16.15.1-linux-x64.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x64
only
This is exceedingly unlikely to be related to a tool update, so I intend to merge through it. |
https://github.com/microsoft/vcpkg-tool/releases/tag/2025-01-11
(Note that this is future dated because the original 2025-01-10 attempt failed smoke testing)
Resolves #38184 . Thanks @WangWeiLin-MV !
Related #21218
Resolves #10812 .
Resolves #32522 . Thanks @lesomnus !
Resolves #43063 . Thanks @autoantwort !
Resolves #43086 .
Also thanks to @vicroms and @Neumann-A !
This PR MUST be merged, not squashed.