Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exprtk] Update to 0.0.3, and use that version scheme #43193

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 10, 2025

This PR extends #43036 by @ArashPartow to make use of the version version scheme. This would bring exprtk in vcpkg on a par with other package repositories, cf.
Packaging status

It uses upstream's license file for copyright.

Alternative to #43036, #42996, #42173. Similar suggestions were made as review comments but unfortunately no consensus was reached.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 10, 2025
@ArashPartow
Copy link
Contributor

ArashPartow commented Jan 10, 2025

@dg0yt please close this PR as there is already PRs waiting to be merged.


@BillyONeal / @MonicaLiu0311 / @PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL : I think there's an issue wrt @dg0yt behaviour here that may need to be resolved offline with MS Personnel.

Copy link
Contributor

@ArashPartow ArashPartow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close this PR as per: #43193 (comment)

@valgur
Copy link
Contributor

valgur commented Jan 10, 2025

I think there's an issue wrt @dg0yt behaviour here that may need to be resolved offline with MS Personnel.

@ArashPartow Please stop assuming bad faith from regular contributors, your behavior is bordering on abusive:

@ArashPartow
Copy link
Contributor

@valgur Can you please tell me what is "vulgar" about requesting a random non-tagged commit of a library not be placed in a long term package management system?

@valgur Please if it is possible refrain from injecting yourself into a situation you clearly have little to not knowledge of.

@@ -1,10 +1,11 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO ArashPartow/exprtk
REF 806C519C91FD08BA4FA19380DBF3F6E42DE9E2D1
SHA512 A323CCAF161FD0087FD8208D1B24C2A3FD422F8875E29B22AE70E6DD2F10F396F6BF1AD36D3FFDC10D32314AE8F83749974301A349BE0F27733292BCF5193640
REF ${VERSION}
Copy link
Contributor Author

@dg0yt dg0yt Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting a random non-tagged commit of a library not be placed in a long term package management system?

FTR this PR uses REF ${VERSION} which maps to tag 0.3.0, given the version from vcpkg.json.

@ArashPartow
Copy link
Contributor

FTR this PR uses REF ${VERSION} which maps to tag 0.3.0, given the version from vcpkg.json.

@dg0yt : My comment from #43193 (comment) was not directed at you or this PR, which btw you merely copied from my PR and did nothing else other than to uppercase the hex values.

The comment was instead directed at @valgur and his libellous statements.


As requested previously, if it is at all possible please refrain from involving yourself with ExprTk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants