-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exprtk] Update to 0.0.3, and use that version scheme #43193
base: master
Are you sure you want to change the base?
Conversation
@dg0yt please close this PR as there is already PRs waiting to be merged. @BillyONeal / @MonicaLiu0311 / @PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL : I think there's an issue wrt @dg0yt behaviour here that may need to be resolved offline with MS Personnel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please close this PR as per: #43193 (comment)
@ArashPartow Please stop assuming bad faith from regular contributors, your behavior is bordering on abusive: |
@@ -1,10 +1,11 @@ | |||
vcpkg_from_github( | |||
OUT_SOURCE_PATH SOURCE_PATH | |||
REPO ArashPartow/exprtk | |||
REF 806C519C91FD08BA4FA19380DBF3F6E42DE9E2D1 | |||
SHA512 A323CCAF161FD0087FD8208D1B24C2A3FD422F8875E29B22AE70E6DD2F10F396F6BF1AD36D3FFDC10D32314AE8F83749974301A349BE0F27733292BCF5193640 | |||
REF ${VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting a random non-tagged commit of a library not be placed in a long term package management system?
FTR this PR uses REF ${VERSION}
which maps to tag 0.3.0
, given the version from vcpkg.json
.
@dg0yt : My comment from #43193 (comment) was not directed at you or this PR, which btw you merely copied from my PR and did nothing else other than to uppercase the hex values. The comment was instead directed at @valgur and his libellous statements. As requested previously, if it is at all possible please refrain from involving yourself with ExprTk. |
This PR extends #43036 by @ArashPartow to make use of the
version
version scheme. This would bring exprtk in vcpkg on a par with other package repositories, cf.It uses upstream's license file for copyright.
Alternative to #43036, #42996, #42173. Similar suggestions were made as review comments but unfortunately no consensus was reached.