Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anari] Update to 0.12.1 #43188

Merged
merged 9 commits into from
Jan 23, 2025
Merged

[anari] Update to 0.12.1 #43188

merged 9 commits into from
Jan 23, 2025

Conversation

tarcila
Copy link
Contributor

@tarcila tarcila commented Jan 10, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@tarcila tarcila marked this pull request as ready for review January 10, 2025 02:36
ports/anari/portfile.cmake Outdated Show resolved Hide resolved
ports/anari/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 10, 2025
@tarcila
Copy link
Contributor Author

tarcila commented Jan 10, 2025

@dg0yt Thanks for the fast review. I've been addressing your comments.

@tarcila tarcila requested a review from dg0yt January 10, 2025 15:45
@JonLiu1993
Copy link
Member

@tarcila, The following file should not be in the share file directory. The share folder stores configuration files, copyright, documents, readme and some miscellaneous items.
image

@jeffamstutz
Copy link

@JonLiu1993 do you have a suggestion where those sources could go? The ANARI-SDK has a "source library" target that it exports that embeds those sources into downstream targets that link it (anari::anari_viewer). It's an uncommon thing to do, but it is expected. I'm open to suggestions for better places to put it (I maintain the ANARI-SDK).

@JonLiu1993
Copy link
Member

I see that the upstream CMakeLists.txt has compiled your exported .cpp. You just need to export the required .h files to the
${CURRENT_PACKAGES_DIR}\include directory.
https://github.com/KhronosGroup/ANARI-SDK/blob/next_release/src/anari_viewer/CMakeLists.txt#L35-L44

@JonLiu1993
Copy link
Member

Ping @tarcila for response.

@tarcila
Copy link
Contributor Author

tarcila commented Jan 20, 2025

@JonLiu1993 Sorry for my delayed response, I was away for a few days.

I've been updating the port to 0.12.1 to integrate @jeffamstutz export header fix.

As for the sources in the shared folder, it's about how ANARI distributes those extra components:

  • It's relying on ImGUI and following its source distribution model, that is sources are to be embed in the target project.
  • Those are extra components that are not having a completely defined API/ABI compatilibty story, hence this copy in your source tree policy.

I hope the above makes sense. If share is not the right folder to hold that, what would you advise?

@tarcila tarcila changed the title [anari] Update to 0.12.0 [anari] Update to 0.12.1 Jan 20, 2025
versions/a-/anari.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 22, 2025
@JonLiu1993
Copy link
Member

@tarcila, The following file should not be in the share file directory. The share folder stores configuration files, copyright, documents, readme and some miscellaneous items. image

@vicroms, Could you please take a look?

@vicroms vicroms merged commit 01be99f into microsoft:master Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants