Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libb2] Enable windows, cleanup #42952

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[libb2] Enable windows, cleanup #42952

merged 2 commits into from
Jan 3, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 26, 2024

Use vcpkg-make.

@dg0yt dg0yt marked this pull request as ready for review December 27, 2024 00:10
@WangWeiLin-MV WangWeiLin-MV added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 27, 2024
@dg0yt dg0yt mentioned this pull request Dec 27, 2024
Closed
7 tasks
@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft December 27, 2024 09:25
@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 31, 2024

@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft

Why? Fixing the baseline regressions is out of scope for this PR.

@dg0yt dg0yt marked this pull request as ready for review December 31, 2024 14:23
WangWeiLin-MV
WangWeiLin-MV approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux
  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jan 3, 2025
@JavierMatosD JavierMatosD merged commit f5eea2e into microsoft:master Jan 3, 2025
17 checks passed
@dg0yt dg0yt deleted the libb2 branch January 4, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @WangWeiLin-MV @JavierMatosD