-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcpkg-tool to 2024-12-09. #42608
Conversation
vcpkg_find_acquire(7z) should give use the full 7zip as a.7z.exe, the tool should unpack that. ✅
Problem: |
1e8a794
to
d17e80c
Compare
d17e80c
to
0c4cf19
Compare
Note that this PR needs to be landed using administrative permissions as a MERGE, not a squash, as we need 0c4cf19 to be accessible 'forever' as it is burned into that matching tool release. |
Full rebuild triggered here: https://dev.azure.com/vcpkg/public/_build/results?buildId=110261&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking 'request changes' so that we don't forget to merge rather than squash.
VS smoke test passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test with example ports intel-mkl
and gmp
, download files checked:
- vcpkgTools.xml
{VCPKG_DOWNLOADS}/downloads/tools/7zr-24.09-windows/7zr.exe
{VCPKG_DOWNLOADS}/downloads/7z2409.7z.exe
{VCPKG_DOWNLOADS}/downloads/LLVM-15.0.6-win64.exe
- win32_extract_self_extracting_7z
{VCPKG_DOWNLOADS}/downloads/7z2409.7z
- extract_archive
{VCPKG_DOWNLOADS}/downloads/tools/7zip-24.09-windows/7z.exe
- vcpkg_extract_archive.cmake
{VCPKG_DOWNLOADS}/downloads/tools/clang/clang-15.0.6/bin/clang.exe
{VCPKG_DOWNLOADS}/downloads/tools/7z/24.09/7z.exe
https://github.com/microsoft/vcpkg-tool/releases/tag/2024-12-09
Also uses vcpkg.exe to unpack 7z.exe archives.
This fixes a bug with
vcpkg_find_acquire(CLANG)
since we are currently downloading its archive as a 7z.exe even though it is not a 7z archive.The following are additional meaningful tool changes:
GITHUB_SERVER_URL
to change GitHub API host for dependency graph submission by @luncliff in UseGITHUB_SERVER_URL
to change GitHub API host for dependency graph submission vcpkg-tool#1547Thank you contributors!