-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcpkg_extract_archive: Use vcpkg.exe z-extract #42370
Conversation
vcpkg_find_acquire(7z) should give use the full 7zip as a.7z.exe, the tool should unpack that. ✅
Problem: |
Changed |
I merged with master due to #42491 merging for a CVE fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge this into master.
Instead, assuming https://github.com/microsoft/vcpkg/ is origin, please:
git fetch origin
git merge origin/master
git reset origin/master
git commit -am "The commit text you're happy to put into vcpkg's history."
git push origin 7z_extraction
and close this PR.
We'll can use that resulting commit SHA in a tool release.
(I would follow the instructions myself but I want you to be listed as the author of the commit and I'm unwilling to git blame-someone-else
to do that)
Hmmm.... Azure seems unhappy for some reason. No reason to think those failures are related to changes here yet. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Uses vcpkg.exe to unpack 7z.exe archives.
This causes a bug with
vcpgk_find_acquire(CLANG)
since we are currently downloading its archive as a7z.exe
even though it is not a7z
archive. The tool cannot unpack it.