Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Luau] Add new port to luau #42101

Merged
merged 12 commits into from
Nov 12, 2024
Merged

[Luau] Add new port to luau #42101

merged 12 commits into from
Nov 12, 2024

Conversation

sssooonnnggg
Copy link
Contributor

@sssooonnnggg sssooonnnggg commented Nov 11, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 11, 2024
ports/luau/cmake-config-export.patch Outdated Show resolved Hide resolved
@FrankXie05
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.

@FrankXie05 FrankXie05 marked this pull request as draft November 11, 2024 07:27
@sssooonnnggg sssooonnnggg marked this pull request as ready for review November 11, 2024 08:04
@sssooonnnggg
Copy link
Contributor Author

Thanks for the review,make namespace unofficial now. If the official repo adds official exports in the future, we can remove this patch. cc @FrankXie05 @dg0yt

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

Required package name: unofficial-luau
Required namespace: unofficial::luau::

FTR I wonder if this can be installed simultaneously with lua or luajit.

@sssooonnnggg
Copy link
Contributor Author

sssooonnnggg commented Nov 11, 2024

@dg0yt Yes, I have tested luau can be installed simultaneously with lua and luajit. Their libs have different names and headers are installed into different sub folders:

  • lua => include/...
  • luau => include/luau/...
  • luajit => include/luajit/...

@sssooonnnggg
Copy link
Contributor Author

Hi, can you help with reviewing again? 😊 @FrankXie05

@FrankXie05
Copy link
Contributor

The usage has been tested successfully locally on x64-windows.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
@vicroms vicroms merged commit 2f78986 into microsoft:master Nov 12, 2024
16 checks passed
@sssooonnnggg sssooonnnggg deleted the luau branch November 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants