Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[realsense2] Update to 2.56.2 #41984

Merged
merged 16 commits into from
Nov 15, 2024

Conversation

MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Nov 6, 2024

Fixes #38635. Update realsense2 to 2.56.2.
Remove outdated patches fix-osx.patch and ${ARM64_DETECTION_FIX}.
Add and fix dependency nlohmann-json.
Add fix-android-prefix-path.patch to fix android prefix path.

Feature openni2 is tested successfully in the following triplets:

x86-windows
x64-windows

Feature tools is tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found).

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Nov 6, 2024
@MonicaLiu0311
Copy link
Contributor Author

Error on Android:

[221/222] cd /mnt/vcpkg-ci/b/realsense2/arm-neon-android-dbg && /android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar -M < /mnt/vcpkg-ci/b/realsense2/arm-neon-android-dbg/realsense2-all.ar
FAILED: /librealsense2-all.a 
cd /mnt/vcpkg-ci/b/realsense2/arm-neon-android-dbg && /android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar -M < /mnt/vcpkg-ci/b/realsense2/arm-neon-android-dbg/realsense2-all.ar
/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/llvm-ar: error: /librealsense2-all.a: Permission denied
ninja: build stopped: subcommand failed.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 15, 2024

error: /librealsense2-all.a: Permission denied

This seems to be lacking a prefix path and should be fixed as part of the update.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review November 15, 2024 08:58
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Nov 15, 2024
@vicroms vicroms merged commit f37984f into microsoft:master Nov 15, 2024
16 checks passed
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/update_realsense2 branch November 18, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[realsense2] update to 2.55.1
4 participants