-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI with android NDK r27c #40339
CI with android NDK r27c #40339
Conversation
Why? Just set the required policy in the toolchain? |
Sounds aggressive. Ask Google.
My plan is to do just that, in scripts/toolchains/android.cmake. |
Looked into the versions. It looks like 3.3 (not 3.5) is the minimum necessary |
https://github.com/android/ndk/wiki/Changelog-r27:
Also https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Page-sizes Q: Shall 16KiB be the default for NDK r27 arm64-android? OTOH it isn't more urgent than raising the API level. |
Reads like: Words, has no sound.... ¯\(ツ)/¯ Don't mind me asking stupid questions. Q: Shall there be a special arm64-v8a triplet? |
Initial success:
|
I have difficulties to get CMP0057 from the toolchain scope ( Testing the proposed fix to the NDK instead. |
This works: diff --git a/scripts/toolchains/android.cmake b/scripts/toolchains/android.cmake
index d675d06a73..4564f29e7e 100644
--- a/scripts/toolchains/android.cmake
+++ b/scripts/toolchains/android.cmake
@@ -31,6 +31,11 @@ endif()
include("${ANDROID_NDK_HOME}/build/cmake/android.toolchain.cmake")
+if(ANDROID_NDK_MAJOR STREQUAL "27")
+ # https://github.com/android/ndk/issues/2032#issuecomment-2274923977
+ string(APPEND CMAKE_SYSTEM_CUSTOM_CODE "cmake_policy(SET CMP0057 NEW)\n")
+endif()
+
if(NOT _VCPKG_ANDROID_TOOLCHAIN)
set(_VCPKG_ANDROID_TOOLCHAIN 1)
But it might be a somewhat tight binding to both CMake and NDK script code. |
Success with patch to NDK's
*) successfuild builds from the first run were cached and not tested again |
This reverts commit 9dc1f7f.
Initial success with r27b:
|
Initial success with r27c:
x64-android errors:
|
Okay, waiting for #41647 arriving as an image. |
There is one more conflicting item. |
Resolved. |
New LTS Version
https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Page-sizes
CI with android NDK r27c #40339 (comment)
Problems:
See also https://github.com/orgs/android/projects/19
[FR] push/pop required policies in cmake toolchain file android/ndk#2032
'ALooper_pollAll' is unavailable: obsoleted in Android 1 - ALooper_pollAll may ignore wakes. Use ALooper_pollOnce instead.