Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make qtbase dependencies explicit in various ports #38151

Closed
wants to merge 6 commits into from

Conversation

geiseri
Copy link
Contributor

@geiseri geiseri commented Apr 12, 2024

This came out of the discussion with @dg0yt on #38138. I found a few other ports that depended on qtbase directly and added the explicit feature dependencies. I did not make any other changes to the version, patches, or port file behavior.

My verification was to run .\vcpkg.exe install --dry-run --host-triplet x64-windows qtbase[core] with each of the updated port's feature enabled to ensure that only the requested features are added. I tried to inspect the build options for mapnik but it doesn't look like it needs any other dependencies.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 13, 2024

qcore:x64-linux:

-- Could NOT find WrapDBus1 (missing: DBus1_LIBRARY DBus1_INCLUDE_DIR WrapDBus1_FOUND) (Required is at least version "1.2")
CMake Warning at /mnt/vss/_work/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Found package configuration file:

    /mnt/vcpkg-ci/installed/x64-linux/share/Qt6DBus/Qt6DBusConfig.cmake

  but it set Qt6DBus_FOUND to FALSE so package "Qt6DBus" is considered to be
  NOT FOUND.  Reason given by package:

  Qt6DBus could not be found because dependency WrapDBus1 could not be found.

  Configuring with --debug-find-pkg=WrapDBus1 might reveal details why the
  package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Strange. qcoro deps are right, and Qt dbus files are installed.

@geiseri
Copy link
Contributor Author

geiseri commented Apr 13, 2024

@dg0yt what platform are you using? I cannot duplicate this on Ubuntu 24.04. I am wondering if this could have snuck in from an unrelated qtbase change. I am using a virtual machine and not a docker container, so maybe the system as a whole is causing it to work.

@dg0yt
Copy link
Contributor

dg0yt commented Apr 13, 2024

@dg0yt what platform are you using? I cannot duplicate this on Ubuntu 24.04. I am wondering if this could have snuck in from an unrelated qtbase change.

I checked the failure logs from CI, available as "artifacts" on Azure Pipelines.

@geiseri
Copy link
Contributor Author

geiseri commented Apr 13, 2024

I checked the failure logs from CI, available as "artifacts" on Azure Pipelines.

Ah okay, yeah that was what I looked at, but I was hoping you saw it elsewhere =)

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 15, 2024
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here:

CMake Error at /mnt/vss/_work/1/s/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
  Found package configuration file:

    /mnt/vcpkg-ci/installed/x64-linux/share/Qt6/Qt6Config.cmake

  but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
  FOUND.  Reason given by package:

  Failed to find required Qt component "DBus".

  Expected Config file at
  "/mnt/vcpkg-ci/installed/x64-linux/share/Qt6DBus/Qt6DBusConfig.cmake"
  exists



  Configuring with --debug-find-pkg=Qt6DBus might reveal details why the
  package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Call Stack (most recent call first):
  cmake/QCoroFindQt.cmake:19 (find_package)
  CMakeLists.txt:84 (qcoro_find_qt)


-- Configuring incomplete, errors occurred!

@geiseri
Copy link
Contributor Author

geiseri commented Apr 19, 2024

@MonicaLiu0311 correct, my issue is that I cannot seem to duplicate it locally to debug it. I have tried with Debian, Ubuntu, and alpine linux with no success. Is there something special about the CI environment? Is there a way to kick off ci with the current version? I am not wondering if this is not a new failure.

@geiseri
Copy link
Contributor Author

geiseri commented May 9, 2024

I'll resubmit without qcoro.

@geiseri geiseri closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants