-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make qtbase dependencies explicit in various ports #38151
Conversation
qcore:x64-linux:
Strange. qcoro deps are right, and Qt dbus files are installed. |
@dg0yt what platform are you using? I cannot duplicate this on Ubuntu 24.04. I am wondering if this could have snuck in from an unrelated qtbase change. I am using a virtual machine and not a docker container, so maybe the system as a whole is causing it to work. |
I checked the failure logs from CI, available as "artifacts" on Azure Pipelines. |
Ah okay, yeah that was what I looked at, but I was hoping you saw it elsewhere =) |
Please get failure logs here:
|
@MonicaLiu0311 correct, my issue is that I cannot seem to duplicate it locally to debug it. I have tried with Debian, Ubuntu, and alpine linux with no success. Is there something special about the CI environment? Is there a way to kick off ci with the current version? I am not wondering if this is not a new failure. |
I'll resubmit without qcoro. |
This came out of the discussion with @dg0yt on #38138. I found a few other ports that depended on
qtbase
directly and added the explicit feature dependencies. I did not make any other changes to the version, patches, or port file behavior.My verification was to run
.\vcpkg.exe install --dry-run --host-triplet x64-windows qtbase[core]
with each of the updated port's feature enabled to ensure that only the requested features are added. I tried to inspect the build options formapnik
but it doesn't look like it needs any other dependencies../vcpkg x-add-version --all
and committing the result.