-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zlmediakit] update zlmediakit to 20240330.0 #37654
Conversation
Can you explain why you're adding a default feature like this? Other than that everything seems reasonable to me... |
Many newcomers who are just getting started don't know how to use vcpkg and zlmediakit. Enabling all features by default can reduce their mental burden, and there is no cost to doing so. |
The problem is that getting default features to be off can be difficult for customers to do, for example: #35694 In general, we try to avoid making a feature default unless the resulting library is ~broken without one. For example, a libarchive with no archive backends is worthless.
There are costs to doing so because this adds a dependency on that feature for callers who might not be expecting this. Is there a particular thing about |
Tagging vcpkg-team-review because we need to discuss how we describe how default features are to be used |
OK, i had disabled sctp default, and pushed new commits, thanks! |
Thanks for the update! |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.