[ffmpeg] srt support #26679

fran6co · 2022-09-04T18:21:24Z

fran6co · 2022-09-04T18:28:18Z

libsrt was generating srt_static.lib instead of srt.lib on Windows and that was breaking the static build. Added a patch to force the correct name so pkgconfig finds it

fran6co · 2022-09-04T18:56:57Z

Actually it still doesn't work.
It's linking against this libs srt.lib libssl.lib libcrypto.lib crypt32.lib ws2_32.lib but I'm getting this errors:

libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_DeregisterEventSource referenced in function OPENSSL_showfatal
libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_RegisterEventSourceW referenced in function OPENSSL_showfatal
libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_ReportEventW referenced in function OPENSSL_showfatal
libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_GetProcessWindowStation referenced in function OPENSSL_isservice
libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_GetUserObjectInformationW referenced in function OPENSSL_isservice
libcrypto.lib(libcrypto-lib-cryptlib.obj) : error LNK2019: unresolved external symbol __imp_MessageBoxW referenced in function OPENSSL_showfatal
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptAcquireContextW referenced in function capi_ctx_set_provname
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptReleaseContext referenced in function capi_ctx_set_provname
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptDestroyKey referenced in function capi_dsa_free
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptSetHashParam referenced in function capi_dsa_do_sign
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptGetProvParam referenced in function capi_list_containers
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptGetUserKey referenced in function capi_get_key
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptExportKey referenced in function capi_get_pkey
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptDecrypt referenced in function capi_rsa_priv_dec
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptCreateHash referenced in function capi_dsa_do_sign
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptDestroyHash referenced in function capi_dsa_do_sign
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptSignHashW referenced in function capi_dsa_do_sign
libcrypto.lib(libcrypto-lib-e_capi.obj) : error LNK2019: unresolved external symbol __imp_CryptEnumProvidersW referenced in function capi_get_provname

fran6co · 2022-09-04T18:57:10Z

Something is missing in openssl pkgconfig

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5#5
old SHA: fb562cf04b1b6b6bddf38d79bf36f456f72b5a56
new SHA: 067a790dfd1559e77d5a199ccbe982322882d667
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

fran6co · 2022-09-04T19:27:53Z

Fixed by adding -ladvapi32 -luser32 to libcrypto deps

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

fran6co · 2022-09-05T07:43:16Z

Arm windows is failing at the package osg with something that looks unrelated:

CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE (advanced)
   _OPENTHREADS_ATOMIC_USE_WIN32_INTERLOCKED_EXITCODE__TRYRUN_OUTPUT (advanced)
``

fran6co · 2022-09-05T07:45:26Z

Not sure what is going with uwp

dg0yt · 2022-09-05T11:37:39Z

Arm windows is failing at the package osg with something that looks unrelated:

osg:arm64-windows also fails for #26676 (comment).

JonLiu1993 · 2022-09-06T08:52:33Z

@fran6co, From the ci error log it looks like it should be caused by not finding OpenEXR after a long list of warnings,

This warning is for project developers.  Use -Wno-dev to suppress it.

-- The following OPTIONAL packages have been found:

 * OpenGL
 * Jasper
 * LibXml2
 * GDAL
 * GTA
 * CURL
 * SDL2, low level access to audio, keyboard, mouse, joystick, and graphics hardware, <https://www.libsdl.org/>
 * GIFLIB
 * JPEG
 * ZLIB
 * PNG
 * TIFF
 * Threads
 * Fontconfig
 * Freetype
 * EXPAT

-- The following OPTIONAL packages have not been found:

 * EGL
 * ilmbase
 * OpenCascade
 * COLLADA
 * FBX
 * LibVNCServer
 * DirectShow
 * Poppler-glib
 * RSVG
 * GtkGl
 * DirectInput
 * NVTT
 * ZeroConf
 * LIBLAS
 * QuickTime

-- The following REQUIRED packages have not been found:

 * OpenEXR

-- Configuring incomplete, errors occurred!

fran6co · 2022-09-06T09:16:35Z

Is the OpenEXR problem related to the changes to this PR?

JonLiu1993 · 2022-09-06T09:42:05Z

Is the OpenEXR problem related to the changes to this PR?

OpenEXR is related to osg, osg is not related to ffmpeg

JonLiu1993 · 2022-09-08T07:00:30Z

/azp run

azure-pipelines · 2022-09-08T07:00:42Z

Azure Pipelines successfully started running 1 pipeline(s).

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-09-27T07:10:30Z

@fran6co, please fix the conflicting file, thanks.

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

fran6co · 2022-09-27T08:41:41Z

@JonLiu1993 done, but I don't know why it fails on uwp builds. The logs are a bit confusing to me, it says that it cascaded or something

fran6co · 2022-09-27T08:43:19Z

https://dev.azure.com/vcpkg/public/_build/results?buildId=78286&view=logs&j=afe306fb-88a0-5d5e-2934-71aa01507316&t=5029ab74-fefd-5c62-0657-5855530a064d&l=7171

fran6co · 2022-09-27T08:52:22Z

Sorted, srt doesn't support uwp

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-09-28T02:26:44Z

@fran6co, If the ci test failed error is not related to this pr, I will rerun ci, this is my error log, you can take a look

fatal: unable to access 'https://code.qt.io/qt/qtinterfaceframework.git/': transfer closed with outstanding read data remaining`

github-actions

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

scripts/test_ports/vcpkg-ci-ffmpeg/vcpkg.json

Valid values for the license field can be found in the documentation

fran6co · 2022-10-02T16:01:13Z

It seems that everything is working now

JonLiu1993 · 2022-10-08T10:18:29Z

Feature srt tested successfully in the following triplet:

x64-windows
x64-windows-static

github-actions bot previously approved these changes Sep 4, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via 25afc95 September 4, 2022 18:25

fran6co force-pushed the ffmpeg-srt branch from 142258b to 25afc95 Compare September 4, 2022 18:25

github-actions bot previously approved these changes Sep 4, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via 7ab3ef4 September 4, 2022 19:26

fran6co force-pushed the ffmpeg-srt branch from 25afc95 to 7ab3ef4 Compare September 4, 2022 19:26

github-actions bot requested changes Sep 4, 2022

View reviewed changes

fran6co force-pushed the ffmpeg-srt branch from 7ab3ef4 to ab358d4 Compare September 4, 2022 19:27

github-actions bot previously approved these changes Sep 4, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via 1ddf244 September 4, 2022 19:30

fran6co force-pushed the ffmpeg-srt branch from ab358d4 to 1ddf244 Compare September 4, 2022 19:30

github-actions bot previously approved these changes Sep 4, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via a95dc04 September 4, 2022 19:34

fran6co force-pushed the ffmpeg-srt branch from 1ddf244 to a95dc04 Compare September 4, 2022 19:34

github-actions bot approved these changes Sep 4, 2022

View reviewed changes

Adela0814 assigned JonLiu1993 Sep 5, 2022

JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 5, 2022

dg0yt mentioned this pull request Sep 6, 2022

[vcpkg baseline][osg] Fix port dependencies and build errors #26698

Merged

github-actions bot previously approved these changes Sep 15, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via a4cbf29 September 19, 2022 13:37

fran6co force-pushed the ffmpeg-srt branch from 60f2ae5 to a4cbf29 Compare September 19, 2022 13:37

github-actions bot previously approved these changes Sep 19, 2022

View reviewed changes

JonLiu1993 added the requires:author-response label Sep 27, 2022

fran6co dismissed github-actions[bot]’s stale review via b154d5f September 27, 2022 08:37

fran6co force-pushed the ffmpeg-srt branch from a4cbf29 to b154d5f Compare September 27, 2022 08:37

github-actions bot previously approved these changes Sep 27, 2022

View reviewed changes

fran6co dismissed github-actions[bot]’s stale review via 8c8156e September 27, 2022 08:51

fran6co force-pushed the ffmpeg-srt branch from b154d5f to 8c8156e Compare September 27, 2022 08:51

github-actions bot previously approved these changes Sep 27, 2022

View reviewed changes

[ffmpeg] srt support

50088eb

fran6co dismissed github-actions[bot]’s stale review via 50088eb September 29, 2022 09:21

fran6co force-pushed the ffmpeg-srt branch from 8c8156e to 50088eb Compare September 29, 2022 09:21

github-actions bot approved these changes Sep 29, 2022

View reviewed changes

JonLiu1993 removed the requires:author-response label Oct 8, 2022

JonLiu1993 approved these changes Oct 8, 2022

View reviewed changes

JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 8, 2022

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 8, 2022

vicroms merged commit a29baaf into microsoft:master Oct 9, 2022

fran6co deleted the ffmpeg-srt branch October 9, 2022 04:55

Sibras mentioned this pull request Jan 15, 2023

[ffmpeg with libsrt and x264 support] #12623

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ffmpeg] srt support #26679

[ffmpeg] srt support #26679

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

github-actions bot left a comment

fran6co commented Sep 4, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

fran6co commented Sep 5, 2022

fran6co commented Sep 5, 2022

dg0yt commented Sep 5, 2022

JonLiu1993 commented Sep 6, 2022

fran6co commented Sep 6, 2022

JonLiu1993 commented Sep 6, 2022

JonLiu1993 commented Sep 8, 2022

azure-pipelines bot commented Sep 8, 2022

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Sep 27, 2022

github-actions bot left a comment

fran6co commented Sep 27, 2022

fran6co commented Sep 27, 2022

fran6co commented Sep 27, 2022

github-actions bot left a comment

JonLiu1993 commented Sep 28, 2022

github-actions bot left a comment

fran6co commented Oct 2, 2022

JonLiu1993 commented Oct 8, 2022

[ffmpeg] srt support #26679

[ffmpeg] srt support #26679

Conversation

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

fran6co commented Sep 4, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

fran6co commented Sep 4, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

fran6co commented Sep 5, 2022

fran6co commented Sep 5, 2022

dg0yt commented Sep 5, 2022

JonLiu1993 commented Sep 6, 2022

fran6co commented Sep 6, 2022

JonLiu1993 commented Sep 6, 2022

JonLiu1993 commented Sep 8, 2022

azure-pipelines bot commented Sep 8, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Sep 27, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

fran6co commented Sep 27, 2022

fran6co commented Sep 27, 2022

fran6co commented Sep 27, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Sep 28, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

fran6co commented Oct 2, 2022

JonLiu1993 commented Oct 8, 2022