[vcpkg script] Add support for Android to make and meson #26570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 8b0c36b0d267841b8502558b0dc75f8528f12d1f
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
m-kuhn
changed the title
JonLiu1993
added
the
category:port-feature
JonLiu1993
requested changes
Aug 29, 2022
|
@JonLiu1993 what kind of changes are still requested? |
@m-kuhn, No need to request changes for now, I'm just waiting for the test results from ci. |
|
Unrelated failure fixed in #26564 |
JonLiu1993
added
depends:different-pr
Neumann-A
reviewed
Sep 10, 2022
Neumann-A
reviewed
Sep 10, 2022
Neumann-A
reviewed
Sep 10, 2022
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-08-28
old SHA: ace9b3e66bfd3fc51e7837248a340fbad446fe65
new SHA: 7e553bacbf36f1404249e24bc25340056a79e897
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
m-kuhn
commented
Sep 13, 2022
|
JackBoosY
added
the
depends:different-pr
|
@m-kuhn It's nice for you still doing the effort to merge the patch. Hope you could complete this time. |
Neumann-A
added a commit
to Neumann-A/vcpkg
that referenced
this pull request
Sep 14, 2022
vicroms
pushed a commit
that referenced
this pull request
Oct 13, 2022
* test osx stuff * deactivate most of ci * get trace output * add required flags to the linker flags * also look for --sysroot * Link_args are always shared * fix ar flags * setup FOR_BUILD vars. * try tricking the build.... but man configure scripts are stupid sometimes... * try 2 * major meson rewrite * fix duplicates * revert --trace-expand * update port version * revert pipeline changes * v db * bump version * v db * set flags for rc compilers * a few more ios fixes. * v db * fix osx/ios logic * documentation and don't fatal_error in build/host machine entry calculation. * add android/compiler target stuff from #26570 * remove extra endif * v db * add target param to linker flags. * target in cpp flags * Make vcpkg-cmake-get-vars more ios compatible * Update scripts/get_cmake_vars/CMakeLists.txt Co-authored-by: Matthias Kuhn <[email protected]> * More ios fixes * fix target adding * Fix broken loop * v db * v db * bump date * v db * v db * v db * remove port-version 1 * v db Co-authored-by: JackBoosY <[email protected]> Co-authored-by: Matthias Kuhn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android support for vcpkg_configure_make (tested with current LTR r25)
Drops
arm-neon-androidand enablesneononarm-android. Non-neon is no longer available in r25. Removal of this is not strictly required by this PR. If there are reasons to keep this it can be added again.What does your PR fix?
Fixes New Android NDK support request #21345 [android] Android NDK r23 and clang support #20844 [icu:arm-android] build failure #18941
Builds on top of #21847
Time to rebuild the world once again
CC @holmesconan