-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opencv4] Changed dependency on qt5 to qt5-base, closes microsoft/vcpkg#11138 #11201
Conversation
@NancyLi1013 I assume you meant bump -1 to -2 ? There's no -4 here... |
can you please do the same change also in opencv3 and opencv2 packages? |
opencv is the metapackage. It should be better to update the version of the opencv4 package too... |
@BillyONeal and @cenit I meant we also needed to update the version for |
59c78fe
to
494b50c
Compare
Somehow I missed the 4 :) |
@BillyONeal bumped the version in opencv4, I made @cenit suggestion to make the same mods to opencv3 |
If you merge your PR with master you can apply the same mod also to opencv2 |
61fe86d
to
3b583d5
Compare
Cools, thanks @venabled :) |
Resolves the circular dependency causing
CASCADED_DUE_TO_MISSING_DEPENDENCIES
identified by @cenit in #11138 by changing the dependency of theqt
feature fromqt5
toqt5-base
What does your PR fix?
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?