Suppress meaningless CodeQL warning. #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is intended to detect accidentally running malicious code where a value rather than code is expected, for example the 'shellshock' bug. If we were trying to communicate what should be sanitized data between processes this warning would be appropriate, but this is used for things like
vcpkg envwhich is intended to run arbitrary user-supplied shell input.It's possible that there are places in vcpkg which would use this function inappropriately; effectively, the analysis needs to bubble up to the code that calls the execute_process* family, but CodeQL doesn't appear to understand this.