Enable multi-package depend-info, track triplets
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables feature control for dependencies.
dg0yt
commented
Mar 24, 2024
Comment on lines
+467
to
+470
| if (strategy.show_depth) | ||
| { | ||
| msg::write_unlocalized_text(Color::error, "(0)"); // legacy | ||
| } |
There was a problem hiding this comment.
Entirely pointless, but kept for compatibility: output depth at top level tree (actually digraph now) nodes.
(Suggesting removal.)
Thomas1664
reviewed
Mar 24, 2024
|
|
||
| std::unordered_set<std::string> features{install_action.feature_list.begin(), | ||
| install_action.feature_list.end()}; | ||
| features.erase(FeatureNameCore.to_string()); | ||
|
|
||
| auto& port_name = install_action.spec.name(); | ||
| out.push_back({decorated_name(install_action.spec), 0, std::move(features), std::move(dependencies)}); |
There was a problem hiding this comment.
Using emplace_back here would allow us to get rid of the calls to back below.
BillyONeal
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
This approval is subject to the documentation being updated to reflect the interface change: https://learn.microsoft.com/vcpkg/commands/depend-info done
https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/commands/depend-info.md
BillyONeal
approved these changes
Mar 26, 2024
|
Thanks for the awesome new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables feature control for dependencies, as in
Fixes microsoft/vcpkg#36604.
For this to work reasonably, it is necessary to make
depend-infotriplet-aware, so this is included in this PR in the following way.:host(instead of using the actual host triplet), to limit variation in output and to simplify recognizing host packages.Examples:
For valid
dotformat output, this PR depends on #1369.