-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github issue body size #1257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs tests. append_log
and append_logs
both look unit testable.
(Note: making testable may require sucking the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM after the size_t<->int
issues are fixed. Thanks for the tests!
Thanks! |
In the past I sometimes got errors like
With this PR the body size is enforced and dynamically distributed between the logs that are copied into the issue body.