Fix edit command.

[BillyONeal]

Fix edit command I broke in 81c8bed

PROC_THREAD_ATTRIBUTE_HANDLE_LIST rejects a list of length 0. Instead, just pass false to bInheritHandles in the CreateProcess call.

[ras0219-msft]

Can we end-to-end test this by setting EDITOR to something innocuous like echo?

[BillyONeal]

Can we end-to-end test this by setting EDITOR to something innocuous like echo?

That won't work because the console of the editor isn't connected to the launching console. I suppose we could write a program whose job in life is to write a sentinel file or something.

[BillyONeal]

Can we end-to-end test this by setting EDITOR to something innocuous like echo?

No, this path is only used for VS Code:

#if defined(_WIN32)
        auto editor_exe = env_editor.filename();
        if (editor_exe == "Code.exe" || editor_exe == "Code - Insiders.exe")
        {
            // note that we are invoking cmd silently but Code.exe is relaunched from there
            cmd_execute_background(Command("cmd").string_arg("/d").string_arg("/c").raw_arg(
                Strings::concat('"', cmd_line.command_line(), R"( <NUL")")));
            Checks::exit_success(VCPKG_LINE_INFO);
        }
#endif // ^^^ _WIN32