Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clangcl community triplets #76

Closed
wants to merge 5 commits into from

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Apr 28, 2023

Draft documentation for clangcl triplets as proposed here.

@prmerger-automator
Copy link

@walbourn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 76b45b6:

⚠️ Validation status: warnings

File Status Preview URL Details
vcpkg/users/platforms/clangcl.md ⚠️Warning View Details

vcpkg/users/platforms/clangcl.md

  • Line 45, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/cpp/build/media/clang-install-vs2022.png?view=msvc-170' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 26, Column 200: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/windows/uwp/cpp-and-winrt-apis/' will be broken in isolated environments. Replace with a relative link.
  • Line 45, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/cpp/build/media/clang-install-vs2022.png?view=msvc-170' will be broken in isolated environments. Replace with a relative link.
  • Line 57, Column 195: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/cpp/build/clang-support-msbuild?view=msvc-170#custom_llvm_location' will be broken in isolated environments. Replace with a relative link.
  • Line 57, Column 195: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/cpp/build/clang-support-msbuild?view=msvc-170#custom_llvm_location

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5256a30:

💡 Validation status: suggestions

File Status Preview URL Details
vcpkg/users/platforms/clangcl.md 💡Suggestion View Details

vcpkg/users/platforms/clangcl.md

  • Line 57, Column 195: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /cpp/build/clang-support-msbuild?view=msvc-170#custom_llvm_location

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 3b65322:

💡 Validation status: suggestions

File Status Preview URL Details
vcpkg/users/platforms/clangcl.md 💡Suggestion View Details

vcpkg/users/platforms/clangcl.md

  • Line 55, Column 195: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /cpp/build/clang-support-msbuild?view=msvc-170#custom_llvm_location

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b4d170c:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/users/platforms/clangcl.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 37d20f7:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/users/platforms/clangcl.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@walbourn walbourn closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants