Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground version picker #2661

Merged
merged 23 commits into from
Nov 17, 2023

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Nov 10, 2023

fix #2044

image

Copy link
Contributor

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2661/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2661/

@timotheeguerin timotheeguerin marked this pull request as ready for review November 10, 2023 22:42
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell. Does this mean we need to publish versioned directories of build artifacts on the playground site so that earlier versions can be imported?

@timotheeguerin
Copy link
Member Author

Looks good as far as I can tell. Does this mean we need to publish versioned directories of build artifacts on the playground site so that earlier versions can be imported?

If we do actually want to allow older version than 0.49 yeah, we should be able to write a script that download each older version of our package tgz, decompress it run the bunlder on it and upload it but I am not sure this is really needed.

@daviwil
Copy link
Contributor

daviwil commented Nov 16, 2023

Ahhh yeah, I wasn't even talking about historical versions, just the strategy going forward.

@timotheeguerin
Copy link
Member Author

Oh for next version it is already taken care of, it will publish automatically if the version has not been published(in the same way we publish to npm) I did that a week or 2 ago #2587

@timotheeguerin timotheeguerin merged commit 86569b3 into microsoft:main Nov 17, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the feature/version-picker branch November 17, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground for prior versions of TypeSpec
3 participants