Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify scalar's url in overview.md #2648

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

lonyehan
Copy link
Contributor

@lonyehan lonyehan commented Nov 8, 2023

fixed the scalars's url

fixed the scalars's url
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2648/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2648/

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonyehan for the fix. Just to note fixing the docs in docs/ folder will apply to the next version of the docs if you wanted to fix the latest as well can you make the same cahnge in packages/website/versioned_docs/latest

@lonyehan
Copy link
Contributor Author

lonyehan commented Nov 8, 2023

Thanks @lonyehan for the fix. Just to note fixing the docs in docs/ folder will apply to the next version of the docs if you wanted to fix the latest as well can you make the same cahnge in packages/website/versioned_docs/latest

Thanks @timotheeguerin for remind me that.
I will modify the document in packages/website/versioned_docs/latest too.

@lonyehan
Copy link
Contributor Author

lonyehan commented Nov 8, 2023

@microsoft-github-policy-service agree

@timotheeguerin timotheeguerin merged commit 8697f61 into microsoft:main Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants