Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default must be last #2636

Merged

Conversation

timotheeguerin
Copy link
Member

default entry must be last in exports. Most tools do not care but it seems like webpack and docusaurus do. This is causing issue when trying to imoport the playground directly there.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status):
Playground: https://cadlplayground.z22.web.core.windows.net/prs/2636/

Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2636/

Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs, or force merge?

@timotheeguerin timotheeguerin enabled auto-merge (squash) November 6, 2023 22:32
@timotheeguerin timotheeguerin merged commit 3695abb into microsoft:main Nov 6, 2023
10 checks passed
@timotheeguerin timotheeguerin deleted the fix/default-must-be-last branch November 6, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants