Fix: Augment decorators might not run if alias caused the type to be resolved too early #2603
+114
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://tspwebsitepr.z22.web.core.windows.net/prs/2603/ |
timotheeguerin
requested review from
bterlson,
daviwil,
markcowl and
allenjzhang
as code owners
daviwil
approved these changes
Oct 30, 2023
timotheeguerin
added a commit
that referenced
this pull request
Oct 31, 2023
This PR #2603 resolved an issue where resolving meta types would cause types to be checked too early but this broke some late bound symbol resolution. It would return the declaration symbol when `checkTemplateTypes` is false but would cache it. So in some cases it would then resolve the wrong symbol later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is that when resolving symbol in the meta types and member resolution when we resolve an alias or template instance we check the type. However this makes it that every referenced typed from there on has already been resolved by the time the augment decorator gets to do the binding.
A fix for now is to have an option in the symnbol resolution to checkTemplateTypes or not. We do not check them during the binding phase but we do allow checking during the checking phase
#2600