-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler] Named instantiation of template arguments #2546
Merged
witemple-msft
merged 26 commits into
microsoft:main
from
witemple-msft:compiler/named-template-params
Dec 18, 2023
Merged
Changes from 10 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e12eec0
[compiler] Support named arguments in template instantiation.
willmtemple 96b710c
Some improvements
willmtemple 55259a0
More advanced test cases
willmtemple df34146
Some final updates
willmtemple 2c18475
Feed linter/cspell
willmtemple 1d419eb
Implement and test semantic colorization, test formatting.
willmtemple cfce419
rush change
willmtemple f824689
Update language guide template docs
willmtemple 2d6ccc9
Merge remote-tracking branch 'upstream/main' into compiler/named-temp…
willmtemple cc72254
Completion, hovers, and improved error recovery
willmtemple 038c6fd
Resolved parameter/argument confusion
witemple-msft 85f794f
Merge remote-tracking branch 'upstream/main' into compiler/named-temp…
witemple-msft ec7210d
More tests
witemple-msft 6ccabdf
Completion tests
witemple-msft 43a5a8c
Address review feedback
witemple-msft 635288d
Updated a test name
witemple-msft 3f84a08
Merge remote-tracking branch 'upstream/main' into compiler/named-temp…
witemple-msft 20baed5
Added a test for typeref with args as an argument name
witemple-msft e631621
Removed an unused destructuring binding.
witemple-msft 1b15d38
Merge branch 'main' into compiler/named-template-params
witemple-msft 646ea66
Merge branch 'main' into compiler/named-template-params
markcowl c03e44f
Update style guide
willmtemple 826ff11
Update packages/compiler/src/formatter/print/printer.ts
witemple-msft ab97df6
Updated an argument that was renamed
willmtemple 42aab3c
Merge remote-tracking branch 'upstream/main' into compiler/named-temp…
willmtemple 78bc214
a typo
willmtemple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
common/changes/@typespec/compiler/compiler-named-template-params_2023-10-10-02-34.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"changes": [ | ||
{ | ||
"packageName": "@typespec/compiler", | ||
"comment": "Added support for named template arguments (#2340)", | ||
"type": "none" | ||
} | ||
], | ||
"packageName": "@typespec/compiler" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the naming convention doc to say how to name template param (pascal case without
T
?)