Update naming logic.

microsoft · Nov 16, 2023 · fed834d · fed834d
1 parent ff40416
commit fed834d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/packages/openapi3/src/openapi.ts b/packages/openapi3/src/openapi.ts
@@ -1320,11 +1320,8 @@ function createOAPIEmitter(
           !paramModels.has(type) &&
           !shouldInline(program, type)
         ) {
-          getSchemaOrRef(type, Visibility.Read);
-        // TODO: This was the old fix...
-        // if (!processedSchemas.has(type) && !paramModels.has(type) && !shouldInline(program, type)) {
-        //   getSchemaOrRef(type, Visibility.All);
-        // }
+          getSchemaOrRef(type, Visibility.All);
+        }
       };
       const skipSubNamespaces = isGlobalNamespace(program, serviceNamespace);
       navigateTypesInNamespace(

diff --git a/packages/samples/test/output/visibility/@typespec/openapi3/openapi.yaml b/packages/samples/test/output/visibility/@typespec/openapi3/openapi.yaml
@@ -114,7 +114,7 @@ components:
         relatives:
           type: array
           items:
-            $ref: '#/components/schemas/PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem'
+            $ref: '#/components/schemas/PersonRelativeItem'
     Person:
       type: object
       required:
@@ -176,7 +176,7 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/PersonRelativeCreateOrUpdateItem'
-    PersonReadOrCreateOrUpdateOrDeleteOrQueryItem:
+    PersonItem:
       type: object
       required:
         - id
@@ -200,7 +200,7 @@ components:
         relatives:
           type: array
           items:
-            $ref: '#/components/schemas/PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem'
+            $ref: '#/components/schemas/PersonRelativeItem'
     PersonRelative:
       type: object
       required:
@@ -231,14 +231,14 @@ components:
           $ref: '#/components/schemas/PersonCreateOrUpdateItem'
         relationship:
           type: string
-    PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem:
+    PersonRelativeItem:
       type: object
       required:
         - person
         - relationship
       properties:
         person:
-          $ref: '#/components/schemas/PersonReadOrCreateOrUpdateOrDeleteOrQueryItem'
+          $ref: '#/components/schemas/PersonItem'
         relationship:
           type: string
     PersonRelativeUpdateItem: