CI fixes.

microsoft · Nov 30, 2023 · 8f85ebd · 8f85ebd
1 parent 69ebe03
commit 8f85ebd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 39 deletions.
diff --git a/packages/openapi3/src/visibility-usage.ts b/packages/openapi3/src/visibility-usage.ts
@@ -34,9 +34,10 @@ export function resolveVisibilityUsage(
   const reachableTypes = new Set<Type>(usages.keys());
 
   if (!omitUnreachableTypes) {
+    // Evaluate all unreferenced types and the types they reference with Visibility.All
     const trackType = (type: Type) => {
       if (!usages.has(type)) {
-        navigateReferencedTypes(type, Visibility.Read, (type, vis) =>
+        navigateReferencedTypes(type, Visibility.All, (type, vis) =>
           trackUsageExact(usages, type, vis)
         );
       }

diff --git a/packages/openapi3/test/metadata.test.ts b/packages/openapi3/test/metadata.test.ts
@@ -66,7 +66,7 @@ describe("openapi3: metadata", () => {
           },
         },
       },
-      SharedReadOrCreateOrUpdateOrDelete: {
+      SharedReadOrCreateOrUpdateOrDeleteOrQuery: {
         type: "object",
         required: ["password", "prop"],
         properties: {
@@ -83,7 +83,7 @@ describe("openapi3: metadata", () => {
         properties: {
           c: { type: "string" },
           r: { type: "string", readOnly: true },
-          shared: { $ref: "#/components/schemas/SharedReadOrCreateOrUpdateOrDelete" },
+          shared: { $ref: "#/components/schemas/SharedReadOrCreateOrUpdateOrDeleteOrQuery" },
         },
         required: ["r", "c", "shared"],
       },

diff --git a/packages/samples/test/output/visibility/@typespec/openapi3/openapi.yaml b/packages/samples/test/output/visibility/@typespec/openapi3/openapi.yaml
@@ -123,7 +123,7 @@ components:
         relatives:
           type: array
           items:
-            $ref: '#/components/schemas/PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem'
+            $ref: '#/components/schemas/PersonRelative'
     Person:
       type: object
       required:
@@ -185,31 +185,6 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/PersonRelativeCreateOrUpdateItem'
-    PersonReadOrCreateOrUpdateOrDeleteOrQueryItem:
-      type: object
-      required:
-        - id
-        - secret
-        - name
-        - test
-        - other
-        - relatives
-      properties:
-        id:
-          type: string
-          readOnly: true
-        secret:
-          type: string
-        name:
-          type: string
-        test:
-          type: string
-        other:
-          type: string
-        relatives:
-          type: array
-          items:
-            $ref: '#/components/schemas/PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem'
     PersonRelative:
       type: object
       required:
@@ -240,16 +215,6 @@ components:
           $ref: '#/components/schemas/PersonCreateOrUpdateItem'
         relationship:
           type: string
-    PersonRelativeReadOrCreateOrUpdateOrDeleteOrQueryItem:
-      type: object
-      required:
-        - person
-        - relationship
-      properties:
-        person:
-          $ref: '#/components/schemas/PersonReadOrCreateOrUpdateOrDeleteOrQueryItem'
-        relationship:
-          type: string
     PersonRelativeUpdateItem:
       type: object
       required: