wip

microsoft · Oct 7, 2023 · 48c827d · 48c827d
1 parent 5607d52
commit 48c827d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/openapi3/src/openapi.ts b/packages/openapi3/src/openapi.ts
@@ -845,6 +845,12 @@ function createOAPIEmitter(
       case "declaration":
         return { $ref: `#/components/schemas/${result.name}` };
       case "circular":
+        reportDiagnostic(program, {
+          code: "inline-cycle",
+          format: { type: getOpenAPITypeName(program, type, typeNameOptions) },
+          target: type,
+        });
+        return {};
       case "none":
         return {};
     }
@@ -858,6 +864,12 @@ function createOAPIEmitter(
       case "declaration":
         return result.value as any;
       case "circular":
+        reportDiagnostic(program, {
+          code: "inline-cycle",
+          format: { type: getOpenAPITypeName(program, type, typeNameOptions) },
+          target: type,
+        });
+        return {};
       case "none":
         return {};
     }

diff --git a/packages/openapi3/src/schema-emitter.ts b/packages/openapi3/src/schema-emitter.ts
@@ -150,7 +150,7 @@ export class OpenAPI3SchemaEmitter extends TypeEmitter<
       // shorten type names by removing TypeSpec and service namespace
       namespaceFilter(ns) {
         const name = getNamespaceFullName(ns);
-        return name !== serviceNamespaceName; // TODO FIXME
+        return name !== serviceNamespaceName;
       },
     };
   }