Skip to content

Commit

Permalink
Fix tsp-spector coverage breaking change (#5409)
Browse files Browse the repository at this point in the history
new tsp-spector now needs a required parameter to publish coverage
report. Without this parameter, ci will fail with error

![image](https://github.com/user-attachments/assets/e6a6abb7-fd0c-4ed3-a998-0c4058e12828)
Checked it works in this ci:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4421855&view=results

Co-authored-by: Pan Shao <[email protected]>
  • Loading branch information
pshao25 and Pan Shao authored Dec 19, 2024
1 parent 7dc64d8 commit 3f2d10a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eng/emitters/pipelines/templates/steps/test-step.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ steps:
azureSubscription: "TypeSpec Storage"
scriptType: "bash"
scriptLocation: "inlineScript"
inlineScript: npx tsp-spector upload-coverage --coverageFile ./generator/artifacts/coverage/tsp-spector-coverage-${{ parameters.LanguageShortName }}-standard.json --generatorName ${{ coalesce(parameters.CadlRanchName, parameters.LanguageShortName) }} --storageAccountName typespec --generatorVersion $(node -p -e "require('./package.json').version") --generatorMode standard
inlineScript: npx tsp-spector upload-coverage --coverageFile ./generator/artifacts/coverage/tsp-spector-coverage-${{ parameters.LanguageShortName }}-standard.json --generatorName ${{ coalesce(parameters.CadlRanchName, parameters.LanguageShortName) }} --storageAccountName typespec --containerName coverages --generatorVersion $(node -p -e "require('./package.json').version") --generatorMode standard
workingDirectory: $(selfRepositoryPath)${{ parameters.PackagePath }}

0 comments on commit 3f2d10a

Please sign in to comment.