Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Automation #8

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Improve Test Automation #8

merged 5 commits into from
Sep 29, 2023

Conversation

manbearian
Copy link
Collaborator

@manbearian manbearian commented Sep 29, 2023

  • Add testing of latest Triton with latest Triton-Shared plugin on a daily basis
  • Add testing of LKG Triton with latest Triton-Shared after updates to main
  • Allow testing workflow to easily be invoked with any combination Triton and Triton-Shared commits.

@manbearian manbearian marked this pull request as ready for review September 29, 2023 18:44
@manbearian manbearian changed the title Add Live-Live Testing Improve Test Automation Sep 29, 2023
Copy link

@NathanielMcVicar NathanielMcVicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is very clean! I wanted to verify the manual workflow_dispatch worked, but I couldn't figure out how from the PR. I guess if it's broken we can just have another PR to fix it.

@manbearian
Copy link
Collaborator Author

LGTM, this is very clean! I wanted to verify the manual workflow_dispatch worked, but I couldn't figure out how from the PR. I guess if it's broken we can just have another PR to fix it.

Yeah, as far as i can tell you cannot run the workflow that isn't in main yet (there's an option to run a different version from another branch, but not a new workflow)

@manbearian manbearian merged commit 40584de into main Sep 29, 2023
2 checks passed
@manbearian manbearian deleted the dev/ianb/nightly-testing branch September 29, 2023 20:00
@manbearian
Copy link
Collaborator Author

manbearian commented Sep 29, 2023

@NathanielMcVicar , so far looks good:

  • New workflow worked in a PR (this one)
  • New workflow triggered after this PR merged into main
  • manual workflow works: i tested main/main
  • we'll see if scheduled (nightly) job works, but it should since i already manually tested main/main which is what the scheduled job will invoke.

UPDATE: runs looked good through the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants