Create integration-tests.yml #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manbearian
requested review from
nhat-nguyen,
NathanielMcVicar and
kshama-msft
NathanielMcVicar
approved these changes
Sep 27, 2023
| repository: 'openai/triton' | ||
| ref: '215b2e77a1d92f907bc4addfa3c3ba204028c32e' # known good commit "Add Shared Middle Layer to Triton via Plug-In" | ||
| path: triton | ||
| submodules: 'recursive' |
There was a problem hiding this comment.
nit: This will checkout all the other submodules as well, which we don't need.
edit: especially since you are cloning triton-shared directly into it's third-party directory, so we don't need any submodules at all
There was a problem hiding this comment.
You're absolutely correct, but I'm going to leave this in place. The check-out takes all of 12s and this future proofs us in case we want other submodules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic PR testing
The buld/test workflow is: