Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Several Problems with Auto-Issue Creation #36

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Fix Several Problems with Auto-Issue Creation #36

merged 5 commits into from
Nov 3, 2023

Conversation

manbearian
Copy link
Collaborator

@manbearian manbearian commented Nov 2, 2023 •
edited
Loading

  • Add some logic to reuse existing rolling build failure bug if one exists.
  • Fix misuse of invoking workflow causing rolling build failure
  • several other QoL improvements, cleanup

Users are still not getting notifications :(

@manbearian manbearian force-pushed the dev/ianb/notify-once branch 3 times, most recently from 66de00f to 7f673f8 Compare November 3, 2023 17:00
@manbearian manbearian closed this Nov 3, 2023
@manbearian
Copy link
Collaborator Author

abandoning for now... wil retry later

@manbearian manbearian changed the title update issue instead of creating a new one Fix Several Problems with Auto-Issue Creation Nov 3, 2023
@manbearian manbearian reopened this Nov 3, 2023
nhat-nguyen
nhat-nguyen approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@nhat-nguyen nhat-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Would be great if we can share the "Report failure" step if it's supported 😄

@nhat-nguyen nhat-nguyen merged commit c949445 into main Nov 3, 2023
4 of 5 checks passed
@nhat-nguyen nhat-nguyen deleted the dev/ianb/notify-once branch November 3, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhat-nguyen nhat-nguyen nhat-nguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manbearian @nhat-nguyen