Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: skip PyVista tests on Windows due to segfault #2427

Closed
wants to merge 2 commits into from

Conversation

adamjstewart
Copy link
Collaborator

@banesullivan we are seeing segfaults on Windows starting yesterday. The exact error can be seen here: https://github.com/microsoft/torchgeo/actions/runs/12012402908/job/33530984354

We did not see this error 3 days ago with the exact same versions of Python and PyVista: https://github.com/microsoft/torchgeo/actions/runs/11986395218/job/33419398537

We also don't see this issue on macOS or Linux.

We see a completely different issue for our minimum supported version of PyVista: https://github.com/microsoft/torchgeo/actions/runs/12012402908/job/33530981513

This last log is probably most useful for debugging to figure out exactly what changed.

@adamjstewart adamjstewart added this to the 0.6.2 milestone Nov 26, 2024
@github-actions github-actions bot added the testing Continuous integration testing label Nov 26, 2024
@adamjstewart
Copy link
Collaborator Author

adamjstewart commented Nov 26, 2024

We may actually remove our pyvista dependency in #2428 but it would still be nice to get to the bottom of this. I'm curious what changed (maybe an apt-get update?) that caused the tests to fail. This would also be nice to solve in the releases/v0.6 branch.

@github-actions github-actions bot added the dependencies Packaging and dependencies label Nov 26, 2024
@banesullivan
Copy link

banesullivan commented Nov 26, 2024

Not sure what is causing that segfault, but I noticed you are installing VTK 9.4.0. See https://github.com/microsoft/torchgeo/actions/runs/12012402908/job/33530984354#step:6:164

Collecting vtk (from pyvista==0.44.1->-r requirements/datasets.txt (line 7))
  Downloading vtk-9.4.0-cp311-cp311-win_amd64.whl.metadata (5.4 kB)

We're going to issue a patch release to PyVista that will limit the VTK version later today. See pyvista/pyvista#6872

@adamjstewart
Copy link
Collaborator Author

Ah, looks like VTK 9.4 was released on PyPI just yesterday, that explains why we started having issues yesterday. Let's wait for the patch release instead of skipping tests. Thanks for the quick response!

@banesullivan
Copy link

the segfault on widows with 9.4 may be related to pyvista/setup-headless-display-action#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants