DOFA: fix bug in patch embedding #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a joint effort with @LeWaldm! |
adamjstewart
force-pushed
the
models/dofa
branch
from
e5cbb06 to
763870d
Compare
github-actions
bot
added
the
documentation
|
New model weights have been released. All performance metrics have significantly improved as a result of this bug fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ando-shah discovered a minor bug (1-line) in DOFA with major consequences (performance is sensitive to band order). @ShadowXZT fixed this and is currently retraining the model. I'll update the model weights once this is done and hopefully we can sneak this in to the 0.6.0 release.