-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datamodules: Switch to kornia AugmentationSequential #2147
Conversation
TODO: Tutorials need to be updated once we fully switch to kornia's |
5c37d97
to
c40d8bc
Compare
c40d8bc
to
a0376b8
Compare
a738549
to
d43baf2
Compare
5fb90fb
to
c7ce4f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still confused by some of the dataset changes, but all datamodule changes now look good. I'll see if I can figure out why the tests are failing.
I wish it were this simple... Note that some failing tests are for NonGeoDataModules ( Also note that some tests fail depending on batch size. For example, Most of the failing tests seem to be because the ground truth mask has a channel dimension, which cross-entropy loss does not like. Let me see if I can fix a few. |
The ChesapeakeCVPR dataset is royally screwed up and I'm not touching it, so I'll let you or @calebrob6 solve that one. The problem is that it doesn't use RasterDataset and the mask is sometimes single channel, sometimes multichannel, so you have to be very careful with all dimensions. I'm not even sure our trainer supports multichannel masks. |
7e14613
to
d2b5b01
Compare
b19be82
to
919bbb2
Compare
Is this waiting on Kornia 0.7.4? Trying to decide if this should be in TorchGeo 0.6.0 next week or if we should bump it to a later release. |
85e91bc
to
e34e120
Compare
Kornia 0.7.4. is out :-) |
Yep, reviewing this now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really clean now, thanks for all the hard work on this!
I think the only other place we use our wrapper is in the transforms tutorial? Maybe we can remove that in a separate PR so we don't hold this up.
e34e120
to
151c343
Compare
Switch to kornia's
AugmentationSequential
indatamodules
submoduleCloses #1432
TODO (once kornia 0.7.4 is released):